Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color well enabling does not work if the associated "coloursX" property is on global scope #75

Closed
shysaur opened this issue Mar 23, 2015 · 3 comments

Comments

@shysaur
Copy link
Owner

shysaur commented Mar 23, 2015

In the current MGSFragariaViewModern example, the Attributes color well is an example of this misbehavior.

@balthisar
Copy link

I have a beautiful fix, but I broke something else that I'm trying to resolve before PR'ing it.

@shysaur
Copy link
Owner Author

shysaur commented Mar 23, 2015

OK, it was just to see if you were aware of this.

@balthisar
Copy link

If you have time, take a look at 9184fd8. It's a WIP and I don't want to PR broken code, but it makes the panels work a lot more nicely, auto-hides a lot of disable stuff, and deals well with the color schemes if not all of the properties are available. Oh, and also make all of the scheme files human-readable/editable.

The last thing I'm struggling with is getting MGSColourSchemesController to run its setup only after the NSObjectController is connected to its data. It's 11:00 pm here and I'm tired and frustrated, and I'll have a fresh look at it tomorrow, but at least you'll have a chance to see the direction its going in.

It's a WIP branch and so not nicely segregated, but some of the earlier commits are safe to pull in if you want them -- spacing, first responder stuff -- through 12f626a should be pretty safe.

If you don't pull them, I'll clean clean up the WIP branch before the PR and get them then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants