Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS] Paper edits, etc. #12

Closed
jGaboardi opened this issue Aug 1, 2022 · 0 comments · Fixed by #45
Closed

[JOSS] Paper edits, etc. #12

jGaboardi opened this issue Aug 1, 2022 · 0 comments · Fixed by #45

Comments

@jGaboardi
Copy link
Contributor

jGaboardi commented Aug 1, 2022

xref openjournals/joss-reviews#4620

Paper sections

  • Summary
    • Typos
      • line 11: 'implementations of different methods'
      • line 17/18: 'the overpass API'
    • OSMnx citation
      • line 19: I would keep this JOSS citation and add the add the preferred one:
        • Boeing, G. 2017. OSMnx: New Methods for Acquiring, Constructing, Analyzing, and Visualizing Complex Street Networks. Computers, Environment and Urban Systems 65, 126-139. doi:10.1016/j.compenvurbsys.2017.05.004
      • xref [JOSS] State of the field / References #13
  • Statement of Need
    • Who is the target audience? There is a Statement of Need section, which does an acceptable job at defining the problem, but does not really mention a target audience.
    • line 33: Are the variations actually endless? Maybe something along the lines of 'highly varied flexibility' or the like.
  • Related Software packages
    • There needs to be much more reference to related software projects for tessellation, both in Python and other languages. Here are some examples after a quick search:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant