Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make selector for element to wait for until rendering the page configurable #57

Open
emilic14 opened this issue Mar 10, 2023 · 1 comment

Comments

@emilic14
Copy link

Hello,
First of all thanks! your project is giving my nook a second life ^^.

My bug is related to your
await page.waitForSelector("home-assistant", { timeout: Math.max(config.renderingTimeout - navigateTimespan, 1000) });
Code, as I am personally not using lovelace but I am currently more of a Tileboard user... so this check is blocking.
Easy fix but just thought I would share it.

@sibbl
Copy link
Owner

sibbl commented Mar 11, 2023

That's great to hear!

Probably we could make the selector configurable as well, defaulting to the current value home-assistant.

Will add it to my list (or appreciate a PR) 👍

@sibbl sibbl changed the title Home assistant blocker Make selector for element to wait for until rendering the page configurable Mar 11, 2023
@sibbl sibbl transferred this issue from sibbl/hass-lovelace-kindle-4 Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants