[Bug]: Wrong <input> type for url

[Lapotor]

What happened?

On popups where you have a URL field the <input> type is set to type="href" this is not a valid <input> type.

It should be type="url" to match valid valid <input> type.

ngx-editor/projects/ngx-editor/src/lib/modules/menu/link/link.component.html

Line 23 in 3741a9e

<input type="href" [id]="getId('link-popup-url')" formControlName="href" autocomplete="off" />

ngx-editor/projects/ngx-editor/src/lib/modules/menu/image/image.component.html

Line 23 in 3741a9e

<input type="href" [id]="getId('image-popup-url')" formControlName="src" autocomplete="off" />

Version

v17.5.4

Angular Version

v17.3.9

What browsers are you seeing the problem on?

Firefox

Link to reproduce

No response

Relevant log output

No response

Willing to submit a PR?

Yes

[Lapotor]

There for this rule don't apply to the URL fields:

ngx-editor/projects/ngx-editor/src/lib/editor.component.scss

Lines 326 to 329 in 3741a9e

	input[type='text'],
	input[type='url'] {
	padding: 2px 4px;
	}

[sibiraj-s]

Thanks for catching this, Please raise a PR. will get that deployed soon.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread.