Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message causes rs_replace_table() function not to upload data #10

Closed
Emelieh21 opened this issue Jan 11, 2018 · 2 comments
Closed

Comments

@Emelieh21
Copy link
Contributor

First of all: thanks for the very useful package. I am a frequent user of the rs_replace_table function. However, today I noticed the upload to Redshift from S3 does not continue when a warning occurs.

I got this warning:

<simpleWarning in result_fetch(res@ptr, n = n): Don't need to call dbFetch() for statements, only for queries>

And after that the upload to Redshift was skipped and the tables were deleted again from the S3 bucket.

After removing the line warning = function(w) { print(w) } from the rs_replace_table function in my R session (see replace.R line 97-99), it worked fine again. Not sure if you intended the upload to stop when a warning occurs, but I just wanted to inform you about this issue.

@sicarul
Copy link
Owner

sicarul commented Jan 13, 2018

You are right, the upload shouldn't stop for a warning, my mistake. Can you send a Pull Request with the change?

Thanks!

@sicarul
Copy link
Owner

sicarul commented Jan 16, 2018

Thanks for the PR! Fixed by #12
Closing this issue

@sicarul sicarul closed this as completed Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants