Start testing the gem under Windows #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
add_appveyor
branch
2 times, most recently
from
cc182c2
to
ad6307d
Compare
|
@sickill Just some heads up, I got the chance to run the tests under the latest ruby release on Windows, and they all passed! Appveyor would give more confidence since it tests more rubies, but it seems like this gem still works on Windows. :) |
deivid-rodriguez
force-pushed
the
add_appveyor
branch
2 times, most recently
from
11191e5
to
6954013
Compare
deivid-rodriguez
force-pushed
the
add_appveyor
branch
from
6954013
to
7e98e2c
Compare
|
I configured this in my fork and it works! https://ci.appveyor.com/project/deivid-rodriguez/rainbow/build/7 :) |
|
Awesome @deivid-rodriguez, thanks! |
|
@sickill Thanks! You need to link the project to Appveyor though, otherwise this configuration is useless... See here for configuration instructions, just change RuboCop with Rainbow... :) Also, this commit shouldn't have landed, it was only for debugging. I'll add a PR to revert it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the old second commit in #46 extracted to a separate PR.