Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carry PR #33 - Add String refinement #77

Merged
merged 4 commits into from
Nov 20, 2017
Merged

Carry PR #33 - Add String refinement #77

merged 4 commits into from
Nov 20, 2017

Conversation

olleolleolle
Copy link
Collaborator

@olleolleolle olleolleolle commented Nov 20, 2017

This PR is, in essence, #33 by @mieko - thank you!

  • add a Refinements way of using Rainbow
  • do not make it the default, but document how to use it

Closes #33

@olleolleolle olleolleolle self-assigned this Nov 20, 2017
@olleolleolle
Copy link
Collaborator Author

In #74, some JRuby input made me make this support optional.

@ku1ik
Copy link
Owner

ku1ik commented Nov 20, 2017

I have zero experience with refinements, but the code looks great ;)

@ku1ik ku1ik merged commit 9e566ea into master Nov 20, 2017
@olleolleolle olleolleolle deleted the refinements branch November 20, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants