-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rubocop latest, drop support for Ruby 2.1, 2.2 #91
Conversation
- always use latest rubocop - lint
@sickill Do you agree with this Ruby version policy? (Same as Ruby-the-language's.) |
@sickill Would you want to keep more specific versions in the Gemfile? |
- CI failed in Appveyor, saying psych needs 2.3+ - Update Travis, AppVeyor, RuboCop, gemspec - Lint
- This failed with an error: Gem::RuntimeRequirementNotMetError: psych requires Ruby version >= 2.3, < 2.6. The current ruby version is 2.6.1.33
@olleolleolle in general I believe that if there's no practical, immediate reason to drop support for older language runtime version then one should not drop it. Some people on EOL-ed Ruby (many people are stuck) could benefit from bugfixes and new features if the new gem version doesn't require newer runtime. Frankly, I'm not using Ruby anymore (for few years already) so I'm not sure how many people use older releases, and how many of them are EOL-ed 😬 Having said that, it would definitely be simpler to stick to the same rules as Ruby does, not requiring a case by case decision from us now and then. So let's do this :) And definitely no need for more specific versions in Gemfile 👍 |
🏆 👌 |
@olleolleolle Would you mind releasing a new version so dependencies? My Rubocop is failing due to this error:
|
This PR updates the Gemfile use any (aka latest release of) RuboCop.
2.2+2.3Then lint to the new rules.