Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Incremental Aggregation] Optimise table lookups in querying & synchronise aggregation process function #1310

Merged
merged 7 commits into from
May 22, 2019

Conversation

niveathika
Copy link
Member

@niveathika niveathika commented May 22, 2019

Purpose

$subject, to reduce the memory usage when querying aggregation tables.(Fixes #491)
Synchronize aggregation process method

Goals

Optimize querying aggregation tables.

Approach

Pass aggregation on condition to the tables.

Documentation

N/A

Automation tests

  • Unit tests - 79%
  • Integration tests - N/A

Security checks

@codecov-io
Copy link

codecov-io commented May 22, 2019

Codecov Report

Merging #1310 into master will decrease coverage by 0.18%.
The diff coverage is 32.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1310      +/-   ##
============================================
- Coverage     63.11%   62.92%   -0.19%     
  Complexity       37       37              
============================================
  Files           621      623       +2     
  Lines         25384    25554     +170     
  Branches       3974     4005      +31     
============================================
+ Hits          16020    16081      +61     
- Misses         8088     8193     +105     
- Partials       1276     1280       +4
Impacted Files Coverage Δ Complexity Δ
...o/siddhi/core/aggregation/IncrementalExecutor.java 81.34% <ø> (ø) 0 <0> (ø) ⬇️
.../siddhi/core/aggregation/RecreateInMemoryData.java 52.38% <100%> (+0.57%) 0 <0> (ø) ⬇️
...io/siddhi/core/aggregation/AggregationRuntime.java 92.66% <100%> (+0.75%) 0 <0> (ø) ⬇️
...core/aggregation/AggregationExpressionBuilder.java 21.66% <21.66%> (ø) 0 <0> (?)
...core/aggregation/AggregationExpressionVisitor.java 27.36% <27.36%> (ø) 0 <0> (?)
...dhi/core/util/parser/helper/QueryParserHelper.java 96.1% <0%> (-0.65%) 0% <0%> (ø)
...i/core/util/parser/CollectionExpressionParser.java 38.28% <0%> (+0.9%) 0% <0%> (ø) ⬇️
...ut/stream/state/AbsentStreamPreStateProcessor.java 86.61% <0%> (+1.4%) 0% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e3110...21e35bb. Read the comment docs.

@mohanvive mohanvive merged commit 432365b into siddhi-io:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants