Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TemplateBuilder & remove Java MessageFormat dependency #1431

Merged
merged 3 commits into from
Aug 6, 2019

Conversation

mohanvive
Copy link
Contributor

Purpose

Fix for #858 ...

@codecov-io
Copy link

codecov-io commented Aug 5, 2019

Codecov Report

Merging #1431 into master will decrease coverage by 0.01%.
The diff coverage is 82.6%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1431      +/-   ##
============================================
- Coverage     67.57%   67.56%   -0.02%     
  Complexity       41       41              
============================================
  Files           634      634              
  Lines         26718    26755      +37     
  Branches       4219     4226       +7     
============================================
+ Hits          18055    18076      +21     
- Misses         6892     6907      +15     
- Partials       1771     1772       +1
Impacted Files Coverage Δ Complexity Δ
...io/siddhi/core/util/transport/TemplateBuilder.java 53.96% <82.6%> (+13.96%) 0 <0> (ø) ⬇️
...java/io/siddhi/core/stream/input/InputHandler.java 77.41% <0%> (-3.23%) 0% <0%> (ø)
...e/util/statistics/memory/ObjectSizeCalculator.java 73.58% <0%> (-2.52%) 0% <0%> (ø)
...ut/stream/state/AbsentStreamPreStateProcessor.java 85.21% <0%> (-1.41%) 0% <0%> (ø)
...y/api/execution/query/output/stream/UpdateSet.java 24.44% <0%> (-1.14%) 0% <0%> (ø)
...e/src/main/java/io/siddhi/core/util/Scheduler.java 81.64% <0%> (-0.53%) 0% <0%> (ø)
...core/src/main/java/io/siddhi/core/table/Table.java 27.54% <0%> (-0.48%) 0% <0%> (ø)
.../io/siddhi/core/util/snapshot/SnapshotService.java 71.63% <0%> (-0.42%) 0% <0%> (ø)
...nt/stream/holder/SnapshotableStreamEventQueue.java 75.91% <0%> (-0.4%) 0% <0%> (ø)
...ore/util/parser/helper/DefinitionParserHelper.java 74.48% <0%> (+0.05%) 0% <0%> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b57182...12a4522. Read the comment docs.

mohanvive and others added 2 commits August 5, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants