Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats history issue with custom Date default format #2559

Closed
stan opened this issue Sep 18, 2015 · 2 comments
Closed

Stats history issue with custom Date default format #2559

stan opened this issue Sep 18, 2015 · 2 comments

Comments

@stan
Copy link

stan commented Sep 18, 2015

Sidekiq v3.5.0

I'm using a custom Date::DATE_FORMATS[:default] in my application, and this breaks the expectation that #{Time.now.utc.to_date} will always return something formatted as "%Y-%m-%d".

Not sure if this should be considered an issue on Sidekiq part, but using #{Time.now.utc.strftime "%Y-%m-%d"} instead for the failed and processed history redis keys would fix this.

https://github.com/mperham/sidekiq/blob/master/lib/sidekiq/processor.rb#L106 & https://github.com/mperham/sidekiq/blob/master/lib/sidekiq/processor.rb#L118

@mperham
Copy link
Collaborator

mperham commented Sep 18, 2015

Ack. We partially fixed this in 5133344 but missed those lines. Want to send a PR so you get credit for the fix?

@stan
Copy link
Author

stan commented Sep 21, 2015

Sorry meant to and was sidetracked.. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants