You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unless I'm misunderstanding something, it would make sense to provide a client pool for APNS connections. It would be helpful for those who use this lib with multiple certificates.
My understanding is the ClientConnPool in the http2 libs cannot be used because the underlying Transport is used across all clients in the pool. That wouldn't work for this lib, as the TLS connection is configured with the Apple certificate for each client's transport.
If this is deemed a good idea and a possibility, I'd be willing to start a PR.
The text was updated successfully, but these errors were encountered:
Just to validate this need and offer a PoC, we are currently doing this with a sync.RWLock controlled map[string]*apns.Client where string is the certificate's file name. Would be a good addition to the package.
@c3mb0 That's basically what we're doing, except our key is a md5 of the certificate bytes. I will attempt to integrate our solution to the library and submit a PR this week.
Unless I'm misunderstanding something, it would make sense to provide a client pool for APNS connections. It would be helpful for those who use this lib with multiple certificates.
My understanding is the ClientConnPool in the http2 libs cannot be used because the underlying
Transport
is used across all clients in the pool. That wouldn't work for this lib, as the TLS connection is configured with the Apple certificate for each client's transport.If this is deemed a good idea and a possibility, I'd be willing to start a PR.
The text was updated successfully, but these errors were encountered: