Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Consider using pipenv for managing packages #20

Open
patcon opened this issue May 4, 2018 · 3 comments
Open

Consider using pipenv for managing packages #20

patcon opened this issue May 4, 2018 · 3 comments

Comments

@patcon
Copy link

patcon commented May 4, 2018

Any thoughts on using this tool?
https://docs.pipenv.org/

To explain, I'm having some issues getting the python processing libraries working in an alpine linux docker container. I feel like being a little looser on the specific version constraints in a Pipfile might help people navigate issues like this across systems.

Specifically, there seem to be some off conditions where pandas version X has trouble in docker, and where certain packages must be installed in a specific order -- the alpha order in the requirements.txt doesn't seem to work. Anyhow, I'll sort the specifics elsewhere, but wondering if there's any opposition to using pipenv to generate real dep resolution lockfiles.

Thanks for any consideration

@patcon patcon changed the title Use pipenv Consider using pipenv for managing packages May 4, 2018
@danvk
Copy link
Contributor

danvk commented May 5, 2018

pipenv looks great! Thanks for the pointer. I'd welcome a change to move our requirements.txt file into the new world of Python dependency management.

One distinction that would be nice to draw is between the Python packages that are required for the geocoding work and those that are required for running the site. (This could be dev. vs. prod.) In fact, there should only be Python dependencies for serving the site if you run your own API server (oldtoronto/devserver.py).

@patcon
Copy link
Author

patcon commented May 8, 2018

🙌 pipenv unfortunately only has 2 groups -- packages and dev-packages. but these might work for us. Alternatively, we could just have more clear division between the packages used, and have separate pipenv/requirements files

@danvk
Copy link
Contributor

danvk commented May 9, 2018

I think those two groups should be enough: dev=geocoding pipeline, prod=anything required for serving (currently nothing!).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants