Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guardian druid errors #827

Closed
Hemario opened this issue Jan 24, 2021 · 5 comments
Closed

Guardian druid errors #827

Hemario opened this issue Jan 24, 2021 · 5 comments
Assignees

Comments

@Hemario
Copy link
Contributor

Hemario commented Jan 24, 2021

Describe the bug
Default Ovale Guardian Druid (not TankScripts) constantly throwing errors.

1083x Ovale\ui/Frame.lua:82: attempt to index local 'action' (a nil value)
[string "@Ovale\ui/Frame.lua"]:82: in function `goNextIcon'
[string "@Ovale\ui/Frame.lua"]:164: in function <Ovale\ui/Frame.lua:130>
[string "=(tail call)"]: ?

Locals:
self = <table> {
 actionBar = <table> {
 }
 handleCheckBoxValueChanged = <function> defined @Ovale\ui/Frame.lua:447
 ovaleSpellFlash = <table> {
 }
 baseState = <table> {
 }
 ovaleFuture = <table> {
 }
 iconsFrame = <unnamed> {
 }
 handleDropDownValueChanged = <function> defined @Ovale\ui/Frame.lua:452
 dragHandleTexture = <unnamed> {
 }
 updateIntervalFrame = OvaleUpdateFrame {
 }
 height = 55.800003
 localstatus = <table> {
 }
 content = <unnamed> {
 }
 ovaleCompile = <table> {
 }
 visible = true
 ovaleEnemies = <table> {
 }
 ovaleOptions = <table> {
 }
 OnWidthSet = <function> defined @Ovale\ui/Frame.lua:431
 tracer = <table> {
 }
 ovaleState = <table> {
 }
 traceLog = <table> {
 }
 LayoutFunc = <function> defined @TomTom\libs\AceGUI-3.0\AceGUI-3.0.lua:625
 ovaleDebug = <table> {
 }
 handleContentResize = <function> defined @Ovale\ui/acegui-helpers.lua:45
 userdata = <table> {
 }
 scripts = <table> {
 }
 handleFrameResize = <function> defined @Ovale\ui/acegui-helpers.lua:35
 width = 128.400070
 children = <table> {
 }
 combat = <table> {
 }
 OnHeightSet = <function> defined @Ovale\ui/Frame.lua:439
 type = "Frame"
 checkBoxWidget = <table> {
 }
 petFrame = <unnamed> {
 }
 ovale = <table> {
 }
 base = <table> {
 }
 events = <table> {
 }
 listWidget = <table> {
 }
 runner = <table> {
 }
 ovaleSpellBook = <table> {
 }
 ovaleFrameModule = <table> {
 }
 actions = <table> {
 }
 ovaleBestAction = <table> {
 }
 frame = OvaleIcons {
 }
 controls = <table> {
 }
 timeSinceLastUpdate = 0.244000
}
action = nil
left = 128.400000
top = 0
maxWidth = 128.400000
maxHeight = 42.800000
profile = <table> {
 apparence = <table> {
 }
 standaloneOptions = false
 source = <table> {
 }
 code = "# Based on SimulationCraft profile "T26_Demon_Hunter_Havoc".
#    class=demonhunter
#    spec=havoc
#    talents=3310221

Include(ovale_common)
Include(ovale_demonhunter_spells)


AddFunction waiting_for_momentum
{
 hastalent(momentum_talent) and not buffpresent(momentum_buff)
}

AddFunction waiting_for_essence_break
{
 hastalent(essence_break_talent) and not pooling_for_blade_dance() and not pooling_for_meta() and not spellcooldown(essence_break) > 0
}

AddFunction pooling_for_eye_beam
{
 hastalent(demonic_talent) and not hastalent(blind_fury_talent) and spellcooldown(eye_beam) < gcd() * 2 and furydeficit() > 20
}

AddFunction pooling_for_blade_dance
{
 blade_dance() and fury() < 75 - talentpoints(first_blood_talent) * 20
}

AddFunction pooling_for_meta
{
 not hastalent(demonic_talent) and spellcooldown(metamorphosis) < 6 and furydeficit() > 30
}

AddFunction blade_dance
{
 hastalent(first_blood_talent) or enemies(tagged=1) >= 3 - { talentpoints(trail_of_ruin_talent) + buffpresent(metamorphosis_buf check = <table> {
 }
 overrideCode = ""
 showHiddenScripts = true
 list = <table> {
 }
}
margin = 5
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'action' (a nil value)"

@johnnylam88
Copy link
Contributor

Why is the demon hunter script being used for guardian druid?

@johnnylam88
Copy link
Contributor

Hmmm, maybe that is not accurate. I'll need to check on what values are supposed to be in the profile table.

@Hemario
Copy link
Contributor Author

Hemario commented Jan 25, 2021

Aren't all the profiles loaded in memory anyway? The tracelog just shows a dump of all the data (and truncates it). I doubt that is relevant to the issue.

@johnnylam88
Copy link
Contributor

No, that environment dump in from the WoW Lua Errors is the current custom script, so it's not relevant here.

johnnylam88 added a commit to johnnylam88/Ovale that referenced this issue Jan 25, 2021
@Sidoine Sidoine self-assigned this Jan 26, 2021
Sidoine pushed a commit that referenced this issue Jan 26, 2021
* fix(simulationcraft): improve druid GetInMaleeRange() function

Don't use wild_charge, and instead use wild_charge_bear when in
Bear form and wild_charge_cat when in Cat form.

* fix(druid): regenerate scripts with fixed GetInMeleeRange() function

Fixes issue #827.

* fix(spellbook): verify parameters to IsSpellKnown()

The WoW API function IsSpellKnown() only accepts spell IDs greater
than zero as a vaild parameter, otherwise it throws an error.
@Hemario
Copy link
Contributor Author

Hemario commented Jan 27, 2021

no error any more since Ovale 9.0.45

@Hemario Hemario closed this as completed Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants