Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use github within submodule example #2

Merged
merged 1 commit into from
Aug 16, 2022
Merged

docs: use github within submodule example #2

merged 1 commit into from
Aug 16, 2022

Conversation

bufferoverflow
Copy link
Member

Motivation

use github within submodule example

Proposed Changes

(Write out the details of your proposed changes here.)

Test Plan

(Please provide clear instructions on how to verify that your changes work.)

DDvO
DDvO approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@DDvO DDvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this correction.
Unfortunately I was not aware of his PR for long time.

@DDvO DDvO merged commit 0ef4ded into master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DDvO DDvO DDvO approved these changes

Assignees

@DDvO DDvO

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bufferoverflow @DDvO