Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date selection properties to date/time-picker #50

Closed
nuke-ellington opened this issue Oct 12, 2022 · 1 comment · Fixed by #69
Closed

Add date selection properties to date/time-picker #50

nuke-ellington opened this issue Oct 12, 2022 · 1 comment · Fixed by #69
Assignees
@danielleroux @nuke-ellington
Labels
type: bug Something isn't working
Milestone
1.1.0

Comments

@nuke-ellington
Copy link
Collaborator

nuke-ellington commented Oct 12, 2022 •
edited
Loading

I'm submitting a...


[ ] Bug report
[x] Feature request
[ ] Documentation issue or request

It is not possible to set a custom date/time for all three pickers.

Expected behavior

Custom date/time can be set for all three components.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?
@danielleroux danielleroux added this to the 1.0.1 milestone Oct 12, 2022
@danielleroux danielleroux added type: bug Something isn't working component: core labels Oct 13, 2022
@danielleroux
Copy link
Collaborator

danielleroux commented Oct 13, 2022 •
edited
Loading

We should also add the following properties, but maybe in a different issue?

Datepicker

property desciption
maxDate The latest date that can be displayed or selected.
minDate The earliest date that can be displayed or selected.

Timepicker

@danielleroux danielleroux linked a pull request Oct 18, 2022 that will close this issue
fix(core/date-time-picker): add additional properties to configure datetime pickers #69
Merged
@danielleroux danielleroux changed the title Add inputs for date-/time- & datetime-pickers feat(core/datepicker, core/timepicker, core/datetimepicker): add additional properties Oct 18, 2022
@danielleroux danielleroux mentioned this issue Oct 19, 2022
Merged
@danielleroux danielleroux changed the title feat(core/datepicker, core/timepicker, core/datetimepicker): add additional properties Add date selection properties to date/time-picker Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielleroux danielleroux

@nuke-ellington nuke-ellington

Labels
type: bug Something isn't working
Projects
Siemens iX
Status: Done
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

fix(core/date-time-picker): add additional properties to configure datetime pickers siemens/ix
3 participants
@danielleroux @nuke-ellington @goncalosard