Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/date-time-picker): add additional properties to configure datetime pickers #69

Merged
merged 25 commits into from
Nov 11, 2022
Merged

fix(core/date-time-picker): add additional properties to configure datetime pickers #69

merged 25 commits into from
Nov 11, 2022

Conversation

nuke-ellington
Copy link
Collaborator

Summary

How did you test this change?

@danielleroux danielleroux linked an issue Oct 18, 2022 that may be closed by this pull request
Add date selection properties to date/time-picker #50
Closed
@danielleroux danielleroux added this to the 1.0.1 milestone Oct 18, 2022
@danielleroux danielleroux changed the title Fix/date&time pickers feat(core/datepicker, core/timepicker, core/datetimepicker): add additional properties Oct 18, 2022
@danielleroux danielleroux self-assigned this Oct 18, 2022
danielleroux
danielleroux requested changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@danielleroux danielleroux left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Enhance example of date(-time)-picker (html-test-app)

packages/core/src/components/date-picker/date-picker.tsx Outdated Show resolved Hide resolved
packages/core/src/components/date-picker/test/basic/index.html Outdated Show resolved Hide resolved
packages/core/src/components/date-picker/test/date-picker.e2e.ts Show resolved Hide resolved
packages/core/src/components/datetime-picker/datetime-picker.scss Show resolved Hide resolved
packages/core/src/components/datetime-picker/test/basic/index.html Outdated Show resolved Hide resolved
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Oct 21, 2022
@danielleroux
Copy link
Collaborator

danielleroux commented Nov 4, 2022 •
edited

@nuke-ellington @goncalosard

Please review changes. What i have done in summary:

  • Add an alternative output event to the combined string
  • Add additional types for events
  • Merge main added @since tags
  • Use fromFormat and toFormat consistant in the component
  • add translation of hardcoded string done

Open Points 😶

  • Visual Regression?
  • Unit tests?
  • Improve documentation
  • Examples are broken (min-, max- Date is DateTime which is from luxon and not avaiable on global, convert to module type or refactor min max Date (see review comment))
  • Example code React <> Angular <> Web Components are inconsistent

@danielleroux danielleroux changed the title feat(core/datepicker, core/timepicker, core/datetimepicker): add additional properties fix(core/date-time-picker): add additional properties to configure datetime pickers Nov 4, 2022
@danielleroux
Copy link
Collaborator

@goncalosard Can you please have a look to the top date navigation of the datepicker:
image

It seems to be broken

@danielleroux danielleroux merged commit 30a4d1e into main Nov 11, 2022
@danielleroux danielleroux deleted the fix/date&time-pickers branch November 11, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

Assignees

@nuke-ellington nuke-ellington

Labels
pull request affects minor version The pull request affects only minor version
Projects
Siemens iX
Status: Done
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Add date selection properties to date/time-picker
3 participants
@nuke-ellington @danielleroux @goncalosard