fix(core/button): add space between leading icon and text #149

goncalosard · 2022-11-17T12:26:35Z

Summary

Added a space between the icon and the text on a button.
Used gap to create this space.

Tested locally

…-toogle-button-styling

nuke-ellington

I think we can just put the gap into the main .btn class. Adding an extra class definition just adds unneccessary clutter IMO.

goncalosard and others added 3 commits November 16, 2022 16:41

fix(core): icon and text gap

06e754b

Merge branch 'main' of https://github.com/siemens/ix into fix/toolbar…

f3a043b

…-toogle-button-styling

chore(core): updated snapshots

c0a2675

goncalosard requested a review from nuke-ellington November 17, 2022 12:26

goncalosard added the component: core label Nov 17, 2022

danielleroux changed the title ~~Fix/toolbar toogle button styling~~ fix(core/button): add space between leading icon and text Nov 17, 2022

nuke-ellington requested changes Nov 17, 2022

View reviewed changes

fix(core): corrected class

4665efd

danielleroux added the pull request affects patch version The pull request affects only patch version label Nov 18, 2022

danielleroux added this to the 1.1.0 milestone Nov 18, 2022

danielleroux assigned goncalosard Nov 18, 2022

fix(core/breadcrumb): update styling

ddbad33

nuke-ellington approved these changes Nov 18, 2022

View reviewed changes

danielleroux merged commit 8392ef6 into main Nov 20, 2022

danielleroux deleted the fix/toolbar-toogle-button-styling branch November 20, 2022 19:34