Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/event-list): re-enable chevron and prevent event list from h… #185

Merged
merged 1 commit into from
Nov 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ $height-single-line: 2.5rem;
}

.chevron-icon {
display: none;
margin-left: auto;
margin-right: $small-space;
opacity: 0.6;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class EventListItem {
<div class="event-content">
<slot></slot>
</div>
<i class="glyph glyph-16 glyph-chevron-right chevron-icon"></i>
{ this.chevron ? <i class="glyph glyph-16 glyph-chevron-right chevron-icon"></i> : '' }
</div>
</div>
);
Expand Down
4 changes: 0 additions & 4 deletions packages/core/src/components/event-list/event-list.scss
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ ul {
border-bottom-left-radius: 0;
border-bottom-right-radius: 0;
}

i.glyph {
display: none;
}
}

.compact:not(:last-child) {
Expand Down
33 changes: 33 additions & 0 deletions packages/core/src/components/event-list/test/chevron/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<!--
SPDX-FileCopyrightText: 2022 Siemens AG

SPDX-License-Identifier: MIT
-->

<html>
<head>
<meta charset="utf-8" />
<meta
name="viewport"
content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=5.0"
/>
<title>Stencil Component Starter</title>
</head>
<body>
<ix-event-list>
<ix-event-list-item color="color-primary" disabled chevron
>Text 1</ix-event-list-item
>
<ix-event-list-item color="color-primary" chevron
>Text 2</ix-event-list-item
>
<ix-event-list-item color="color-primary" selected chevron
>Text 3</ix-event-list-item
>
<ix-event-list-item color="color-primary" chevron
>Text 4</ix-event-list-item
>
</ix-event-list>
<script src="http://127.0.0.1:8080/scripts/e2e/load-e2e-runtime.js"></script>
</body>
</html>
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ regressionTest.describe('event-list', () => {
expect(await page.screenshot({ fullPage: true })).toMatchSnapshot();
});

regressionTest('chevron', async ({ page }) => {
await page.goto(`event-list/test/chevron`);
expect(await page.screenshot({ fullPage: true })).toMatchSnapshot();
});

regressionTest('custom-height', async ({ page }) => {
await page.goto(`event-list/test/custom-height`);
expect(await page.screenshot({ fullPage: true })).toMatchSnapshot();
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.