Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/menu-avatar): show avatar icon #201

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

nuke-ellington
Copy link
Collaborator

@nuke-ellington nuke-ellington commented Nov 30, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #195

What is the new behavior?

  • Show avatar again

Does this introduce a breaking change?

  • Yes
  • No

@nuke-ellington nuke-ellington added type: bug Something isn't working component: core pull request affects patch version The pull request affects only patch version labels Nov 30, 2022
@nuke-ellington nuke-ellington added this to the 1.2.0 milestone Nov 30, 2022
@nuke-ellington nuke-ellington self-assigned this Nov 30, 2022
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux modified the milestones: 1.2.0, 1.1.2 Dec 1, 2022
@danielleroux danielleroux merged commit dee02b8 into main Dec 1, 2022
@danielleroux danielleroux deleted the fix/menu-avatar-image branch December 1, 2022 13:30
@danielleroux danielleroux modified the milestones: 1.1.2, 1.2.0 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants