Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menu avatar placeholder image missing #195

Closed
nuke-ellington opened this issue Nov 29, 2022 · 6 comments · Fixed by #375
Closed

menu avatar placeholder image missing #195

nuke-ellington opened this issue Nov 29, 2022 · 6 comments · Fixed by #375
Assignees
Labels
type: enhancement New feature or request
Milestone

Comments

@nuke-ellington
Copy link
Collaborator

nuke-ellington commented Nov 29, 2022

I'm submitting a...


[x] Bug report
[ ] Feature request
[ ] Documentation issue or request

Current behavior

The ix-menu-avatar has an empty grey circle without an illustration of an avatar.

image

@nuke-ellington nuke-ellington added type: bug Something isn't working component: core pull request affects patch version The pull request affects only patch version labels Nov 29, 2022
@danielleroux danielleroux removed the pull request affects patch version The pull request affects only patch version label Nov 30, 2022
@danielleroux
Copy link
Collaborator

@nuke-ellington I removed the patch label, because we must also provide a solution to add custom avatar images.
image

@danielleroux danielleroux added the type: enhancement New feature or request label Nov 30, 2022
@danielleroux danielleroux modified the milestones: next-release, 1.2.0, 1.1.2 Nov 30, 2022
@nuke-ellington nuke-ellington self-assigned this Nov 30, 2022
@danielleroux
Copy link
Collaborator

@nuke-ellington is this issue fixed with #201 or do we want to implement the feature to display an image with this issue?

@nuke-ellington
Copy link
Collaborator Author

@nuke-ellington is this issue fixed with #201 or do we want to implement the feature to display an image with this issue?

@danielleroux I think we might want to take this issue to JF once again and add the image later.

@danielleroux danielleroux added triage We discuss this topic in our internal weekly and removed type: bug Something isn't working labels Dec 5, 2022
@danielleroux danielleroux modified the milestones: 1.1.2, 2.0.0 Dec 6, 2022
@danielleroux danielleroux modified the milestones: 2.0.0, next-release Dec 14, 2022
@danielleroux danielleroux removed the triage We discuss this topic in our internal weekly label Dec 15, 2022
@danielleroux danielleroux modified the milestones: 1.3.0, next-release Dec 19, 2022
@nuke-ellington
Copy link
Collaborator Author

#276

@danielleroux
Copy link
Collaborator

Outcome of JF. Implement first letter feature.

@sn0wcat
Copy link
Member

sn0wcat commented Jan 25, 2023

IMHO the component should let the developer set up the image on his own, by just setting the link.

But, if we are already implementing some default behavior, we should probably use gravatar with fallback to two letter initials. This is what is being delivered by SiemensID in identity claim, and this will probably be the default Identity Provider for the large majority of applications which use iX.

Siemens ID delivers the gravatar image if one is configured, otherwise there is a two letter fallback to

https://i0.wp.com/cdn.auth0.com/avatars/qu.png?ssl=1

Gravatar and Fallback Image:

image

@danielleroux danielleroux self-assigned this Feb 14, 2023
@danielleroux danielleroux linked a pull request Feb 14, 2023 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants