Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/avatar): initals and image support #375

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Feb 14, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Add image support by path
  • Add initails support only used if no image is set

Does this introduce a breaking change?

  • Yes
  • No

Testing

Snapshots added

Other information

Fixed issue regarding wrong home attribute in examples of navigation menu.

@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Feb 14, 2023
@danielleroux danielleroux added this to the 1.4.0 milestone Feb 14, 2023
@danielleroux danielleroux linked an issue Feb 14, 2023 that may be closed by this pull request
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit b586eda into main Feb 16, 2023
@danielleroux danielleroux deleted the 195-menu-avatar-placeholder-image-missing branch February 16, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

menu avatar placeholder image missing
2 participants