Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): siemens sans font added to button #657

Closed
wants to merge 1 commit into from

Conversation

yessGlory17
Copy link

@yessGlory17 yessGlory17 commented Jul 27, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #642

What is the new behavior?

  • The font-family property for the button has been added as Siemens Sans.

Does this introduce a breaking change?

  • Yes
  • No

Testing

I added font-family to .btn class in the file located at packages/core/scss/components/_buttons.scss.

Other information

@danielleroux
Copy link
Collaborator

I closed the Pull request:

  • Visual Regression pipeline was broken
  • Merge conflicts

The issue should already been fixed with #534

@yessGlory17 yessGlory17 deleted the fix-button-font branch September 22, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants