-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more sources types into ImportFactor.from #52
Comments
@Siemienik |
Right, I considered a lot about that. May we should implement first version without this and add it if requested. WDYT? |
@Siemienik |
added todo comment referencing into Siemienik#52
connected with #196 |
As @Metastasis mentioned in #4 (comment). Current factory has possibility only for reading workbook from local file system, what can't works under browser because security purposes.
Actual
The
ImportFactory.from
accept only filePath which is a string:https://github.com/Siemienik/xlsx-import/blob/90c2b76564bd87433de19a9e8f55b9e064d14e09/src/ImporterFactory.ts#L6-L11
Expected
ImportFactory should recognise type of argument and knowing this choose how to handle it.
string
string
string
Buffer|ArrayBuffer
Please keep in mind, that samples Readme link into this issue - should be updated when issue become done.
Further (if requested)
Please do not it now
string
The text was updated successfully, but these errors were encountered: