Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] The paginator #79

Closed
Siemienik opened this issue Oct 31, 2020 · 1 comment
Closed

[Proposal] The paginator #79

Siemienik opened this issue Oct 31, 2020 · 1 comment

Comments

@Siemienik
Copy link
Owner

Siemienik commented Oct 31, 2020

The paginator

I want to propose add possibility to paginate result into xlsx-import, I suppose that should improve performance for larger files. I have no idea how it should be done yet, but this issue is only a proposition. So any ideas are welcome 🤗

Current:

Function getAllItems return all items from imported worksheet

https://github.com/Siemienik/xlsx-import/blob/4c74089/src/Importer.ts#L11-L17

After:

const importer = new PaginatedImporter(workbook);

 importer.getItems(cfg, 0, 100); // 1s "page": {offset:0, amount: 100}

 importer.getItems(cfg, 4*100, 100); // 5th "page": {offset:400, amount: 100}

Possible problems

Afaik, ExcelJS hasn't option to stop and resume function ws.eachRow. We use this function in verticalListStrategy. (probably resolved by: #80)

@Siemienik Siemienik changed the title Propose: The paginator [Proposal] The paginator Nov 1, 2020
@Siemienik Siemienik mentioned this issue Jan 22, 2021
10 tasks
@Siemienik
Copy link
Owner Author

As described in The Index of Proposals (#144), it will be reopened if accepted.

🗣️ 🗣️ 🗣️ 🗣️ Any discussion here is wanted.

Repository owner locked and limited conversation to collaborators Apr 6, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant