Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all tabs opened when restoring a large session #22

Closed
jmmerz opened this issue Oct 31, 2017 · 9 comments
Closed

Not all tabs opened when restoring a large session #22

jmmerz opened this issue Oct 31, 2017 · 9 comments

Comments

@jmmerz
Copy link

jmmerz commented Oct 31, 2017

I have a session with 107 tabs. When I save it, then shut down Firefox, restart and try to restore it, it brings back only a small number of tabs - 15 usually. Once or twice I think I saw it restore a few more like 16 or 17.

This is using Tab Session Manager v1.3.3 on Firefox 56.0.2.

I was concerned that some other extension may be interfering, so I tried again in Safe Mode installing it as a temporary extension and saw the same issue.

@grahamperrin
Copy link

Screen recording one of three

https://youtu.be/sQMGKq8EVp0 (unlisted), at 17:57 on the timeline:

  • for a session with 1,485 tabs, Tab Tally shows 450 tabs loaded.

Firefox 56.0.2 (64-bit) on FreeBSD-CURRENT, Tab Session Manager 1.5.0.

Key frames from this screen recording

2017-11-19 08:32:32

2017-11-19 08 32 32 frame

2017-11-19 08:33:02

2017-11-19 08 33 02 frame

2017-11-19 08:33:06

2017-11-19 08 33 06 frame

2017-11-19 08:33:15

2017-11-19 08 33 15 frame

2017-11-19 09:05:26

2017-11-19 09 05 26 frame

@grahamperrin
Copy link

grahamperrin commented Nov 19, 2017

Screen recording two of three

https://youtu.be/mTQ43G8o5LY (unlisted), with a new, clean profile, after installing just two extensions – Tab Groups and Tab Session Manager – again:

  • for a session with 1,485 tabs, Tab Tally shows 450 tabs loaded

2017-11-19 12 11 20 frame

– in that frame from the recording, we see 451 after I opened a new tab to install the third extension, Tab Tally.

@grahamperrin
Copy link

grahamperrin commented Nov 19, 2017

Five more frames from screen recording two of three
2017-11-19 12:51:49 frame

2017-11-19 12 51 49 frame

2017-11-19 12:52:17 frame

2017-11-19 12 52 17 frame

2017-11-19 12:52:18 frame a

2017-11-19 12 52 18 frame a

2017-11-19 12:52:18 frame b

2017-11-19 12 52 18 frame b

2017-11-19 12:52:30 frame

2017-11-19 12 52 30 frame

… What? Where the hell did that go? …

Screen recording three of three

https://youtu.be/GGjhtz11Rf8 (unlisted), a very short screen recording, focusing on a tab that might have been unexpectedly hidden during recording two (I need to take a closer look at recording two):

2017-11-19 12 56 45 frame

The HTML title and URL of the page in that tab:

  • 1384515 - Provide an API for hiding and showing individual tabs
  • https://bugzilla.mozilla.org/show_bug.cgi?id=1384515

@grahamperrin
Copy link

@sienori there's potentially much to take in, I don't expect you to sit watching screen recordings for hours :-) so please kick back if you would like more refined thoughts from me.

@laggarcia
Copy link

laggarcia commented Nov 21, 2017

I think I am having a similar (or worse) issue. When I try to restore any session, no tabs are restored. The "Open" link apparently does nothing. I am using Firefox 57 on Fedora 27, with the Tab Session Manager version 1.5.0. Is this a separate issue? How can I collect information to help debug this?

@grahamperrin
Copy link

#22 (reference)

@sienori
Copy link
Owner

sienori commented Nov 23, 2017

It should be improved by two changes.
789c4d4
501461d

@hklene
Copy link

hklene commented Nov 26, 2017

@grahamperrin Where did you get that colorful yellow/gree bugzilla-report?

https://user-images.githubusercontent.com/192271/32993002-dea79e30-cd49-11e7-9193-860c4b073ab8.png

Sorry for offtopic, was just curious.

@grahamperrin
Copy link

@sienori sienori closed this as completed Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants