Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Style Tab - Vertical tab tree support? #7

Closed
irvinm opened this issue Oct 3, 2017 · 4 comments
Closed

Tree Style Tab - Vertical tab tree support? #7

irvinm opened this issue Oct 3, 2017 · 4 comments

Comments

@irvinm
Copy link

irvinm commented Oct 3, 2017

Using the vertical tab solution "Tree Style Tab", I am able to manage my tabs vertically and even put them into topic trees. Tab Session Manager is able to store all of the tabs and restore them (minus about:xxx), but isn't able to maintain the relationships.

I am not sure if this request is even possible as I can see that when I am also running "Tree Tabs", that add-on does not see the changes I make using Tree Style Tab.

Test Session:
tree

Restored Session:
non-tree

@pfheatwole
Copy link

pfheatwole commented Oct 4, 2017

I would also appreciate this functionality. If I understand correctly, it should be a simple case of setting openerTabId when recreating the tab.

References (search for openerTabId):

At a glance, it looks like Tab-Session-Manager::saveSession saves the entire Tab, but restores only a few properties when recreating the session. If Tab-Session-Manager::makeTab would pass the property.openerTabId of the saved tab to browser.tabs.create, that might be enough. (Disclaimer: I am neither an extensions developer nor even a JavaScript dev, just an interested user.)

@sienori
Copy link
Owner

sienori commented Oct 5, 2017

That is probably possible.
I will support it in the next version.

@sienori
Copy link
Owner

sienori commented Oct 13, 2017

Supported in 1.3.1

If you replaced the parent-child relationship of tabs, It is impossible to restore completely.
This is because TST does not update the openerTabId when replacing tabs.

@irvinm
Copy link
Author

irvinm commented Oct 17, 2017

@sienori I just wanted to say thanks. I passed your feedback to piroor (TreeStyleTabs) and he has already made the change to update openerTabId. With these 2 changes, it should provide a pretty nice use case with vertical tabs with a session manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants