Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows release #9

Closed
5 tasks
kastolars opened this issue Sep 5, 2019 · 2 comments
Closed
5 tasks

Windows release #9

kastolars opened this issue Sep 5, 2019 · 2 comments
Assignees
@Vineet77
Labels
Priority: Critical Type: Enhancement New feature or request

Comments

@kastolars
Copy link
Member

  • make a branch based off dev called windows_release
  • at project root, run go build -o client
  • remove main.go
  • remove internal/ (yes the whole directory)
  • test to make sure that client -h works

No pull request is needed, all this code remains on this branch.
@Vineet77
Copy link
Member

The branch is up and ready.

@Vineet77
Copy link
Member

Can confirm it works on Windows x86-64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vineet77 Vineet77

Labels
Priority: Critical Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Vineet77 @kastolars