fix: avoid internal arrays in get_all_docs (backport frappe#20950) (f…

…rappe#20958)
sigger · May 10, 2023 · 43b051f · 43b051f
1 parent 8b0c1f8
commit 43b051f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/frappe/public/js/frappe/form/save.js b/frappe/public/js/frappe/form/save.js
@@ -65,7 +65,7 @@ frappe.ui.form.save = function (frm, action, callback, btn) {
 
 			const is_empty_row = function(cells) {
 				for (let i = 0; i < cells.length; i++) {
-					if (locals[doc.doctype][doc.name][cells[i].fieldname]) {
+					if (locals[doc.doctype][doc.name] && locals[doc.doctype][doc.name][cells[i].fieldname]) {
 						return false;
 					}
 				}

diff --git a/frappe/public/js/frappe/model/model.js b/frappe/public/js/frappe/model/model.js
@@ -677,8 +677,8 @@ $.extend(frappe.model, {
 
 	get_all_docs: function(doc) {
 		var all = [doc];
-		for(var key in doc) {
-			if($.isArray(doc[key])) {
+		for (var key in doc) {
+			if ($.isArray(doc[key]) && !key.startsWith("_")) {
 				var children = doc[key];
 				for (var i=0, l=children.length; i < l; i++) {
 					all.push(children[i]);