Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default maximum parameter stepsize #8

Closed
gdmcbain opened this issue Mar 28, 2019 · 2 comments
Closed

default maximum parameter stepsize #8

gdmcbain opened this issue Mar 28, 2019 · 2 comments

Comments

@gdmcbain
Copy link
Contributor

The default maximum parameter stepsize is finite

https://github.com/nschloe/pacopy/blob/b5ae74c2c17349a04165291e2e74fbc865da660b/pacopy/natural.py#L12

and small, depending on the system. A couple of times I have forgotten this and removed the explicit setting, hoping for a faster run through the milestones #6 (Δλ ~ 10², in the example given there, kinnala/scikit-fem#145), only to have it tiptoe at Δλ = 1.

What about defaulting to no limit as for

https://github.com/nschloe/pacopy/blob/b5ae74c2c17349a04165291e2e74fbc865da660b/pacopy/natural.py#L16

?

(Otherwise, pacopy.natural is proving very useful for stationary Navier–Stokes work.)

@nschloe
Copy link
Collaborator

nschloe commented Apr 10, 2019

What about defaulting to no limit as for

Definitely. You can include it in the milestones PR if you want.

@gdmcbain
Copy link
Contributor Author

I was going to add that the change 98d4ccf should also be made in euler_newton, for consistency, but I see that it's already there.

https://github.com/nschloe/pacopy/blob/b5ae74c2c17349a04165291e2e74fbc865da660b/pacopy/euler_newton.py#L46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants