Terminal output display missing after quitting IRust

[tobz1000]

Issue experienced with Bash 4.4.9 and the following terminal emulators:

• LXTerminal 0.3.1
• Guake 3.0.5
• xterm 330

To reproduce:

1. Start irust
2. Close with ctrl-d or ctrl-c
3. Start typing in parent shell

My typed command does not display in the terminal. If I press enter, the command output is displayed; however, line breaks do not return to the start of the line.

Here is a correctly-displayed ls:

Here is the result of ls after closing IRust:

[pzmarzly]

At first I thought it may be a bug in crossterm::Terminal::exit() but it's just a wrapper for std::process::exit(0). Could you try running:

irust && stty sane
irust && tput clear
irust && tput reset

Hopefully at least 1 of these commands should help, and knowing which one does should help sigmaSd fix the issue.

[tobz1000]

Thanks! stty sane and tput reset fix the issue (only one is needed). tput clear doesn't make any difference. Hopefully that helps with a diagnosis...

Let me know if you'd like any more testing.

[sigmaSd]

Hi @tobz1000 @pzmarzly, I should hopefully have time to look into it tomorrow,
thx for helping @pzmarzly!

[sigmaSd]

@tobz1000 can you try 5fe3a57
Its weird that this fixes it, since terminal.exit() does the same thing, I'll probably dig deeper
Edit: Nvm I imagined that terminal.exit() stops the raw mode, guess it doesn't, now everything make sense^^

[tobz1000]

Yep - the patch fixes it, thanks!

Yeah, Terminal::exit is a bit of weird one, pretty much a re-export of sys::exit. But I guess since Terminal doesn't own/know about any RawScreen, it doesn't try to guess the current or previous terminal state.

It seems like it would be cleaner to break out of the control loop and let IRust::run return instead, and relying the RawScreen's Drop implementation to do this instead, but that would require some refactoring.

[sigmaSd]

@tobz1000 I like your idea! I'll keep it in mind for now