Out: IRust: Are you missing a ; ?

[ulidtko]

Hi!

This rather simple code compiles just fine with rustc:

fn parse_troop_power(troops: &str) -> u32 {
    troops.split(' ')
          .map(|w| w.parse::<u32>().expect("input format"))
          .fold(0, |s, x| s + x)
}

But when pasted into IRust, gives weird error:

Curiously, :load from a scratch-file works just fine, too. But it's the whole point of a REPL — to not have to use scratch files right?..

[ulidtko]

irust --version → 0.7.30, FWIW

[sigmaSd]

Hi welcome! As IRust suggest you have to add ';' at the end of the function definition
fn a() {}; instead of fn a() {}

[sigmaSd]

This issue reoccurs I guess I have to add a FAQ in the readme ^^

[smolck]

@sigmaSd The error given by IRust in this case isn’t very helpful IMO because it doesn’t say anything about where the semicolon should go. Most people will probably expect (from other REPLs, like IPython) functions to not require semicolons at the end, and so won’t think to put a semicolon after the function definition. Is there any way we can remove that requirement? Or at least improve the error message?

[sigmaSd]

Hi @smolck ! I think you're right since by now I saw this issue come up a lot of times, maybe we can just special case functions structs and traits maybe?

Here is an initial test 60e541c, 18b78d0 would be great if you test it and report back, I just want to be sure of two things: 1- does it feel now like you expect 2- does it break other things

[sigmaSd]

I found no problem while testing it 195cbec, I think this should be resolved now

[ulidtko]

Yea, looks good to me. Closing!