Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recursive option to repository.tree(sha, recursive=False) #656

Closed
roll opened this issue Dec 8, 2016 · 6 comments
Closed

Add recursive option to repository.tree(sha, recursive=False) #656

roll opened this issue Dec 8, 2016 · 6 comments

Comments

@roll
Copy link

roll commented Dec 8, 2016

Overview

GitHub Tree API allow to get tree recursively - https://developer.github.com/v3/git/trees/#get-a-tree-recursively

Ideas

It should be pretty simple for now it works even like this (a hack):

repository.tree('sha?recursive=1')
--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/39848100-add-recursive-option-to-repository-tree-sha-recursive-false?utm_campaign=plugin&utm_content=tracker%2F183477&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F183477&utm_medium=issues&utm_source=github).
@roll
Copy link
Author

roll commented Dec 8, 2016

For now we could do:

tree.recurse()

but it's second API call (correct me if I'm wrong)

@sigmavirus24
Copy link
Owner

That is a second API call (or more if there's pagination).

It looks like that parameter was added after this part was implemented. I'd be perfectly happy with something like:

repository.tree('sha', recursive=True)

Do you want to send a PR implementing that with tests?

@roll
Copy link
Author

roll commented Dec 12, 2016

I have to dive into your testing framework first so have no time to prepare proper PR now. But this issue should be marked as Easy I suppose.

@itsmemattchung
Copy link
Contributor

If anybody is up for tackling this issue, I'm more than happy to pair and clear up any questions related to testing.

@ghost
Copy link

ghost commented Jul 12, 2017

I'd like to take a stab at it - @itsmemattchung does your offer still stand? I've never pair programmed before; I'm interested to see what that's like

@itsmemattchung
Copy link
Contributor

I'd like to take a stab at it - @itsmemattchung does your offer still stand? I've never pair programmed before; I'm interested to see what that's like

Sure thing! @jmsdvl, shoot me an e-mail, the one listed in my github profile; we can schedule a time that's convenient (I work a pretty typical 9-5) for both of us.

jacquerie added a commit to jacquerie/github3.py that referenced this issue Jul 13, 2018
jacquerie added a commit to jacquerie/github3.py that referenced this issue Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants