-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recursive option to repository.tree(sha, recursive=False)
#656
Comments
For now we could do: tree.recurse() but it's second API call (correct me if I'm wrong) |
That is a second API call (or more if there's pagination). It looks like that parameter was added after this part was implemented. I'd be perfectly happy with something like: repository.tree('sha', recursive=True) Do you want to send a PR implementing that with tests? |
I have to dive into your testing framework first so have no time to prepare proper PR now. But this issue should be marked as |
If anybody is up for tackling this issue, I'm more than happy to pair and clear up any questions related to testing. |
I'd like to take a stab at it - @itsmemattchung does your offer still stand? I've never pair programmed before; I'm interested to see what that's like |
Sure thing! @jmsdvl, shoot me an e-mail, the one listed in my github profile; we can schedule a time that's convenient (I work a pretty typical 9-5) for both of us. |
Overview
GitHub Tree API allow to get tree recursively - https://developer.github.com/v3/git/trees/#get-a-tree-recursively
Ideas
It should be pretty simple for now it works even like this (a hack):
The text was updated successfully, but these errors were encountered: