-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(previews of) missing attachments should not be hidden as if they never existed #12823
Comments
Is this a situation where an attachment fails to download? Or a situation where a user deletes the attachment on a message after receiving it? If the attachment is unreadable, I'm actually much more interested in logs around the attachment failure :) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still very relevant, Signal should not remove any messages from history ever unless a user does that on purpose. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
A tombstone for attachments is still important to have |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been closed due to inactivity. |
Bug description
When for whatever reason an atrachment is missing, Signal Android (and Desktop also, I have not tested iOS) hides any sign of the attachment. For example if someone has once send an image with some text, all I see now is a text message.
This confuses the cconversation history. If we discussed an image or whatever file, there is now just text and I have to guess what might have been send if anything at all.
Signal should show a placeholder, can be a blur hash or something else. That allows me to see what file type was send, and at what moment, part of which message. Even if the filetype is unknown, a placeholder should still be shown to indicate something was there.
On Desktop (not sure about Android) you sonetimes see a download button on a blhr hash and when you click on it and the image can't he found the whole tthing just disappears. Let's not do that.
Screenshots
Device info
Device: Manufacturer Model XVI
Android version: 10.0.0
Signal version: 6.13.5
Link to debug log
The text was updated successfully, but these errors were encountered: