Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(previews of) missing attachments should not be hidden as if they never existed #12823

Closed
3 of 4 tasks
Meteor0id opened this issue Mar 4, 2023 · 7 comments
Closed
3 of 4 tasks
Labels

Comments

@Meteor0id
Copy link
Contributor

Meteor0id commented Mar 4, 2023


Bug description

When for whatever reason an atrachment is missing, Signal Android (and Desktop also, I have not tested iOS) hides any sign of the attachment. For example if someone has once send an image with some text, all I see now is a text message.

This confuses the cconversation history. If we discussed an image or whatever file, there is now just text and I have to guess what might have been send if anything at all.

Signal should show a placeholder, can be a blur hash or something else. That allows me to see what file type was send, and at what moment, part of which message. Even if the filetype is unknown, a placeholder should still be shown to indicate something was there.

On Desktop (not sure about Android) you sonetimes see a download button on a blhr hash and when you click on it and the image can't he found the whole tthing just disappears. Let's not do that.

Screenshots

Device info

Device: Manufacturer Model XVI
Android version: 10.0.0
Signal version: 6.13.5

Link to debug log

@greyson-signal
Copy link
Contributor

Is this a situation where an attachment fails to download? Or a situation where a user deletes the attachment on a message after receiving it? If the attachment is unreadable, I'm actually much more interested in logs around the attachment failure :)

@Meteor0id Meteor0id changed the title missing atrachments should not be hodden as if they never existed (previews of) missing attachments should not be hidden as if they never existed Mar 10, 2023
@stale
Copy link

stale bot commented May 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 9, 2023
@Meteor0id
Copy link
Contributor Author

Still very relevant, Signal should not remove any messages from history ever unless a user does that on purpose.
If messages disappear the remaining message history could be misinterpreted.

@stale stale bot removed the wontfix label May 9, 2023
@stale
Copy link

stale bot commented Jul 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 9, 2023
@Meteor0id
Copy link
Contributor Author

A tombstone for attachments is still important to have

@stale stale bot removed the wontfix label Jul 9, 2023
@stale
Copy link

stale bot commented Sep 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 7, 2023
@stale
Copy link

stale bot commented Sep 16, 2023

This issue has been closed due to inactivity.

@stale stale bot closed this as completed Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants