Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heic not showing as preview #9395

Closed
aquatic7 opened this issue Feb 13, 2020 · 2 comments
Closed

heic not showing as preview #9395

aquatic7 opened this issue Feb 13, 2020 · 2 comments
Labels

Comments

@aquatic7
Copy link


Bug description

When sending and receiving image files to and from contacts I do not see the image when it is in .heic format. Other image types render correctly. Same apply to Desktop version.

Steps to reproduce

  • On android phone, select heic file from gallery
  • Send with signal to another android contact

Actual result: Image preview is not rendered inline. Downloading the image and viewing it in another app works fine.
Expected result: Image is shown in chat

Device info

Device: Samsung Galaxy S10
Android version: 10
Signal version: 4.55.8

Same issue noted for IOS: signalapp/Signal-iOS#4374

bkchr added a commit to bkchr/TextSecure that referenced this issue May 18, 2020
This pr changes the behavior of sending HEIC images to always convert
them to JPEG. This conversion is required to support image inline
viewing accross different devices and operating systems. This follows
the same strategy as on IOS: signalapp/Signal-iOS#2511

Fixes: signalapp/Signal-iOS#4374 & signalapp#9395
@awaitlink
Copy link
Contributor

This should be closed as 4712833 was merged?

@stale
Copy link

stale bot commented Jan 27, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 27, 2022
@stale stale bot closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants