Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal-iOS does not preview heic files correctly #4374

Closed
3 tasks done
skunert opened this issue Feb 8, 2020 · 3 comments
Closed
3 tasks done

Signal-iOS does not preview heic files correctly #4374

skunert opened this issue Feb 8, 2020 · 3 comments
Labels
wontfix

Comments

@skunert
Copy link

skunert commented Feb 8, 2020

  • I have searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

When receiving image files from friends I sometimes do not see the image. I am mostly seeing this bug with friends who use a Galaxy S10 with heic files. Other image types render correctly.

Steps to reproduce

  • On android phone, select heic file from gallery
  • Send with signal to ios contact

Actual result: Image preview is not rendered inline. Downloading the image and viewing it in another app works fine.

Expected result: Image is shown in chat

Screenshots

IMG_0819

Device info

Device: iPhone XS

iOS version: 13.3.1

Signal version: 3.4.1.1

Link to debug log

https://debuglogs.org/49d3e655d0a6f58e24b1289caa59913fd34c083826fef0d63f139f29284a7901.zip
@aquatic7 aquatic7 mentioned this issue Feb 13, 2020
Closed
@bkchr bkchr mentioned this issue Apr 6, 2020
Closed
4 tasks
bkchr added a commit to bkchr/TextSecure that referenced this issue May 18, 2020
@bkchr
Always convert HEIC images to JPEG
aa29277 
This pr changes the behavior of sending HEIC images to always convert
them to JPEG. This conversion is required to support image inline
viewing accross different devices and operating systems. This follows
the same strategy as on IOS: signalapp/Signal-iOS#2511

Fixes: signalapp/Signal-iOS#4374 & signalapp#9395
@awaitlink
Copy link
Contributor

This should be closed as signalapp/Signal-Android@4712833 was merged?

@iMonZ
Copy link

iMonZ commented Jan 13, 2021

New issue:

HEIC files now automatically converted to PNG even if they are uploaded as files!

@stale
Copy link

stale bot commented Jan 24, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 24, 2022
@stale stale bot closed this as completed Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always convert HEIC images to JPEG bkchr/TextSecure
3 participants
@skunert @iMonZ @awaitlink