Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing dependencies breaks on Arch (possibly all non-debian based distros) #1829

Closed
1 task done
veggiedefender opened this issue Nov 28, 2017 · 3 comments
Closed
1 task done

Comments

@veggiedefender
Copy link
Contributor

veggiedefender commented Nov 28, 2017

  • I have searched open and closed issues for duplicates

Bug description

Building Signal-Desktop dependencies fails before completing.

See note at the bottom

Steps to reproduce

  • Be on Arch Linux
  • clone Signal-Desktop
  • run yarn install

Actual result: output

It appears to be trying to set the locale to C.UTF-8, which Arch does not have:

success Already up-to-date.
$ electron-builder install-app-deps && rimraf node_modules/dtrace-provider
electron-builder 19.46.3
Rebuilding native production dependencies for linux:x64
Rebuilding native dependency spellchecker
Rebuilding native dependency websocket
Error: /usr/bin/node exited with code 1
Output:
yarn run v1.3.2
$ node-gyp rebuild
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Error output:
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)

Expected result: Installing dependencies completes without error

Platform info

Operating System: Arch Linux on 4.13.12-1-ARCH

Note: This appears to be related to a bug in electron-builder, but I'm filing an issue here since it directly impacts building Signal.

electron-userland/electron-builder#2340

commercialhaskell/stack#856

@veggiedefender
Copy link
Contributor Author

the electron-builder people fixed this earlier today; bumping electron-builder up to 19.47.0 should fix it.

@JoshStrobl
Copy link

Can confirm the same issue occurs on Solus. I went ahead and have our package script upgrade to electron-builder@19.51.0 and haven't noticed any issues during testing.

Reference: https://dev.solus-project.com/R3823:f8de5c9904a22137cb6d81b05598cadd0246254b

Prodding @scottnonnenberg about maybe treating this with a bit of priority, please? ❤️

@scottnonnenberg
Copy link
Contributor

@JoshStrobl It's in process. #1920

mutantmonkey pushed a commit to mutantmonkey/aur that referenced this issue Jan 30, 2018
Thank you to Jake for finding the source of the build errors!

Github issue: signalapp/Signal-Desktop#1829

Bumped electron-builder to v19.47.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants