Chrome export fixes: too-long names, redact group ids #1402
Conversation
|
These changes look fine, but tangentially, it occurs that we might need to worry about conversation name collisions... |
|
@liliakai What kind of collisions are you concerned about? In our logging? On disk? Both? We do have one technique in place already to avoid this - we include the conversation's Even so, it won't be a huge problem because we operate on conversations in order and we print out log entries for the initial scheduling, so I think we'll be able to figure out what's going on. As far as on disk, we don't use the group ID, we use the name of the conversation to make it more human readable. |
|
I was thinking specifically about the directory name. I have a lot of groups called "test", for instance. |
|
As long as those 'test' groups were last modified at different times, we'll be fine. Though I can imagine one scenario that might make a lot of groups modified at the same time: a safety number change of a group member in every group. Maybe the right thing is to include both the human-readable name and the ID on disk? Same for individuals - both name and phone number? |
|
I didn't see any references to |
|
Hmm I don't think safety number changes modify active_at, but timestamps are somewhat flimsy as unique identifiers... Also, I don't know that human-readability should be a priority, at least not over reliability. |
|
Alright, I'll merge this and assemble another PR. |
Properly handle update of blocked numbers sync'd from mobile device (#1411) Fix some bugs with migration to Electron (still behind a flag) - Dark Theme: Increase banner text contrast for legibility (#1415) - Better disambiguate conversation directory names (#1409) - Handle long group or contact names (#1402) - Redact group ids in export logging (#1402) Better logging - Don't log expiration if queued task threw an error (#1412) - Additional error handling/logging during contact sync (#1395) Remove unknown group messages from cache - no need to retry! (#1414) Update a large number of strings via transifex (#1403) FREEBIE
This user reported a failing export: #1398
Ultimately we discovered that it was due to an extremely long group name. So now we limit group and contact names to 30 characters when we go to the filesystem.
But in the process we realized that the group id is not something we wanted in clear-text. So, as with phone numbers, we only log the last three characters of the group id.