createTaskWithTimeout: Don't log expiration if task threw #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottnonnenberg
added a commit
that referenced
this pull request
Aug 30, 2017
Properly handle update of blocked numbers sync'd from mobile device (#1411) Fix some bugs with migration to Electron (still behind a flag) - Dark Theme: Increase banner text contrast for legibility (#1415) - Better disambiguate conversation directory names (#1409) - Handle long group or contact names (#1402) - Redact group ids in export logging (#1402) Better logging - Don't log expiration if queued task threw an error (#1412) - Additional error handling/logging during contact sync (#1395) Remove unknown group messages from cache - no need to retry! (#1414) Update a large number of strings via transifex (#1403) FREEBIE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some log analysis today uncovered a bug in
createTaskWithTImeout- it was claiming that a task hadn't completed in time when that task threw.With this fix, we now catch anything thrown by the task, call
clearTimer(), then re-throw.