Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageView: Handle change of color to null, call getColor() #1438

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

scottnonnenberg
Copy link
Contributor

When we relied on the actual value of the color property to be supplied to the updateColor() change event listener, sometimes it would be null. Then the conversation bubbles would have no color at all, making the text hard to read.

This happens for iOS users who have been communicating with a phone number, then add a contact for that user. (Because iOS does not supply a color in its contact sync data)

When we relied on the actual value of the color property to be supplied
to the updateColor change event listener, sometimes it would be null.
Then the conversation bubbles would have no color at all, making the
text hard to read.

FREEBIE
@scottnonnenberg scottnonnenberg merged commit 4009a01 into master Sep 7, 2017
@scottnonnenberg scottnonnenberg deleted the null-color branch September 7, 2017 01:19
scottnonnenberg added a commit that referenced this pull request Sep 7, 2017
Fix bug causing contact and group names/colors to be lost (#1437)

Fix broken Swedish translation preventing new installs
(8caecd5)

Fix clear message bubbles when adding contact with previous messages
in iOS (#1438)

Fix message bubble widths on horizontal resizes (#1447)

Remove horizontal scrolling in convo/message lists (#1448)

Update translations for hr, pt_BR and sv
(8dca9c9)

Export (still behind a flag):
  - Limit attachment filename length for Windows path limits (#1439)
  - Reintroduce conversation last-contact date in directory name (#1439)

Add tests for export utility functions (#1439)

FREEBIE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant