Export: Limit path lengths of attachments, add tests #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, reintroduce last contact date in conversation dir name FREEBIE
scottnonnenberg
added a commit
that referenced
this pull request
Sep 7, 2017
Fix bug causing contact and group names/colors to be lost (#1437) Fix broken Swedish translation preventing new installs (8caecd5) Fix clear message bubbles when adding contact with previous messages in iOS (#1438) Fix message bubble widths on horizontal resizes (#1447) Remove horizontal scrolling in convo/message lists (#1448) Update translations for hr, pt_BR and sv (8dca9c9) Export (still behind a flag): - Limit attachment filename length for Windows path limits (#1439) - Reintroduce conversation last-contact date in directory name (#1439) Add tests for export utility functions (#1439) FREEBIE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes:
backup.jshelper functionsThis should make it more likely that we'll succeed on Windows, which has a path length limit.
Bonus: Fix
MessageViewtests, which were failing during code coverage runsNote: This is an export format breaking change, since it changes how attachment filenames are generated. Any attachment filename longer than 30 characters will cause a failure on import if using an older build that doesn't trim filenames.