Don't show notifications for verified state change with yourself #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's confusing to users, and it really doesn't mean anything anyway. FREEBIE
scottnonnenberg
force-pushed
the
verify-self
branch
from
5358f15
to
55ca4dd
Compare
scottnonnenberg
changed the title
|
Note: we actually mark our own identity key in the trust store as VERIFIED during registration/linking, but it's not reflected in the conversation database, which is why it appears to be changing. |
|
Ah, interesting. All of our syncs from trust store to the conversation database are UI-specific: when we're about to show a conversation, when the ConversationView is listening and a new message comes in, etc. So a solution here might be to call |
|
Yeah this change still makes sense. Maybe add a log statement? |
scottnonnenberg
added a commit
that referenced
this pull request
Sep 14, 2017
Force full contact/group import on next launch if not first run (#1476) Performance: Log entry max to 2k, less logging in hot codepaths (#1459) Don't show notification for verified state change with yourself (#1454) Export: Improve usability - timing expectations, install button (#1474) Add Transifex config to git to unblock Electron localization (#1477) Large localization update FREEBIE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though it is possible to verify yourself in Android and iOS, it's confusing to users and it really doesn't mean anything anyway.
Fixes #1451