Force full contact/group import on next launch (if not first run) #1476
Conversation
|
In the past i've used migrations to schedule one-off jobs like this. |
|
Alternatively, if this is only for chrome, you might consider putting it in the onInstalled listener in chromium.js, wherein you can inspect the previous version number and decide whether an import is needed. |
js/background.js
Outdated
| // disable this checking if a user is first registering. | ||
| var key = 'chrome-contact-sync-v0.43.4'; | ||
| if (firstRun) { | ||
| storage.put(key, true); |
There was a problem hiding this comment.
This will re-write 'true' every time we re-register. Slightly better for perf if we drop this and add a && !firstRun to L#156.
Also, I'm not sure if this was the intent but, I note that:
- this code (the init function) runs every time we reconnect to the internet after being offline for a while.
- firstRun will be true on a re-registration, not just a first-registration.
|
I don't see any other prior examples of this kind of thing in the migrations. We can't expect that we're connected to the socket anyway when those things are run, right? Yes, I suppose this is unique to Chrome. If we did the version check, would that still apply to users who skip the I do think this is the best place to do it. And I've made the change to write to storage only that first time through this codepath. |
Force full contact/group import on next launch if not first run (#1476) Performance: Log entry max to 2k, less logging in hot codepaths (#1459) Don't show notification for verified state change with yourself (#1454) Export: Improve usability - timing expectations, install button (#1474) Add Transifex config to git to unblock Electron localization (#1477) Large localization update FREEBIE
As recommended in #1444, this is a one-time contact/group sync on startup. If you're not in the process of registering, of course.