Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception in provisioning cipher #1470

Merged
merged 1 commit into from Sep 13, 2017
Merged

Fix exception in provisioning cipher #1470

merged 1 commit into from Sep 13, 2017

Conversation

liliakai
Copy link
Contributor

Fixes exception seen in #1465 (comment)

@liliakai
Handle provisioning messages with no profile key
6ae91d2 
This can happen while linking to an older mobile client.

// FREEBIE
scottnonnenberg
scottnonnenberg approved these changes Sep 13, 2017
View reviewed changes
Copy link
Contributor

@scottnonnenberg scottnonnenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Such are the perils of being on the latest all the time!

I notice that this error didn't make it into our logs because it was an unhandled promise rejection. Where do we need to put a catch() with logging to prevent that in the future?

@liliakai
Copy link
Contributor Author

#1472 adds logging that should catch this and other errors during the install process.

@scottnonnenberg scottnonnenberg merged commit 876d852 into electron Sep 13, 2017
@scottnonnenberg scottnonnenberg deleted the profiles-electron branch September 13, 2017 18:26
scottnonnenberg pushed a commit that referenced this pull request Sep 15, 2017
@liliakai @scottnonnenberg
Handle provisioning messages with no profile key (#1470)
fc952fb 
This can happen while linking to an older mobile client.

// FREEBIE
scottnonnenberg added a commit that referenced this pull request Sep 15, 2017
@scottnonnenberg
v1.0.25
bf3eb6d 
Update to Emojiset 4.0 (#1482)

Fix unthemed Submit Debug Log dialog (#1479)

Additional logging to help track down socket disconnect problems
(#1469)

Dismiss loading screen if we have network problems (#1466)

Setup:
  On network error during setup, show error screen instead of hanging
  (#1472)
  Allow user to setup new install with pre-profiles mobile device
  (#1470)

Ensure that we stay pinned to Windows taskbar on upgrade (#1473)
Ensure we are in the right category on Linux (#1473)
Ensure that we Heavye the right icon in the GNOME taskbar (#1473)

Transifex config specific to electron, updated translations (#1478)

CI:
  Bypass often-corrupt node_modules/.bin/grunt.cmd on windows (#1481)
  AppVeyor: Reduce build output due to xcopy of all emoji files
  (c2c9cd0)

FREEBIE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottnonnenberg scottnonnenberg scottnonnenberg approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liliakai @scottnonnenberg