Move app theming from IndexView to AppView #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply theming one level higher so it applies to the debug log. // FREEBIE
|
I can't official approve this since I submitted the PR, but the changes are all from Lilia, so here are my comments:
|
scottnonnenberg
added a commit
that referenced
this pull request
Sep 15, 2017
Apply theming one level higher so it applies to the debug log. // FREEBIE
scottnonnenberg
added a commit
that referenced
this pull request
Sep 15, 2017
Update to Emojiset 4.0 (#1482) Fix unthemed Submit Debug Log dialog (#1479) Additional logging to help track down socket disconnect problems (#1469) Dismiss loading screen if we have network problems (#1466) Setup: On network error during setup, show error screen instead of hanging (#1472) Allow user to setup new install with pre-profiles mobile device (#1470) Ensure that we stay pinned to Windows taskbar on upgrade (#1473) Ensure we are in the right category on Linux (#1473) Ensure that we Heavye the right icon in the GNOME taskbar (#1473) Transifex config specific to electron, updated translations (#1478) CI: Bypass often-corrupt node_modules/.bin/grunt.cmd on windows (#1481) AppVeyor: Reduce build output due to xcopy of all emoji files (c2c9cd0) FREEBIE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change applies theming one level higher in the DOM so it affects the debug log popup. It's now in the overall
bodytag instead of its first childdiv.