Set parent window for about/new version, escape to close #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottnonnenberg
added a commit
that referenced
this pull request
Nov 22, 2017
Remove conversation from left pane on 'delete messages' (#1807) 'Reset session' option for a conversation now resolves more error situations (#1796) Import: Link to export docs, make clear that import should only happen once (#1803) Remove last seen indicator if we sent a message in this conversation on another device (#1805) New version dialog (OSX and Windows) should now be less obtrusive (#1795) About dialog can be dismissed with escape key, important on some Linux window managers with minimal chrome (#1795) Dev: - Group changes are better localizable (#1802) - Import: better logging of errors (#1785)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set the parent on the 'new update available' dialog, in the hopes that it doesn't disrupt other things happening on the machine: #1753
A couple changes for the About Window addressing #1750: