Proper session reset: Delete sessions before and after #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that before our move to node-fetch, we ignored JSON.parse() failures: https://github.com/WhisperSystems/Signal-Desktop/pull/1552/files#diff-1103a6aff0f28b6066715c6994278767L37518
Previously we only archived sessions when sending or receiving a 'reset secure session, which didn't match up with the mobile apps.
scottnonnenberg
added a commit
that referenced
this pull request
Nov 22, 2017
Remove conversation from left pane on 'delete messages' (#1807) 'Reset session' option for a conversation now resolves more error situations (#1796) Import: Link to export docs, make clear that import should only happen once (#1803) Remove last seen indicator if we sent a message in this conversation on another device (#1805) New version dialog (OSX and Windows) should now be less obtrusive (#1795) About dialog can be dismissed with escape key, important on some Linux window managers with minimal chrome (#1795) Dev: - Group changes are better localizable (#1802) - Import: better logging of errors (#1785)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a number of people complaining of
Bad MACerrors (like #1296) which can't be solved with a manualreset secure session. This brings our session reset behavior inline with the mobile apps: