Add branch for CiphertextMessageType::SenderKey in sealed_sender_decrypt #494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While starting to use sender keys, I realized that the helper function
sealed_sender_decrypt
doesn't have a branch forCiphertextMessageType::SenderKey
which pushes the responsibility of the (correct) implementation to the caller. This PR fixes this issue.I looked at the source of official Signal clients, and it looks like a few of them call
sealed_sender_decrypt
and then handle these messages themselves on error.There might be a reason why this is designed like this (maybe avoiding breaking the API?) and I'd be glad to hear about it if you don't want to go forward with this change!