Group Details: Show unregistered users in member list

signalapp · Jul 28, 2021 · 4b92e12 · 4b92e12
1 parent e7a2365
commit 4b92e12
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/ts/test-both/util/getGroupMemberships_test.ts b/ts/test-both/util/getGroupMemberships_test.ts
@@ -57,7 +57,7 @@ describe('getGroupMemberships', () => {
       assert.isEmpty(result);
     });
 
-    it('filters out unregistered conversations', () => {
+    it('does not filter out unregistered conversations', () => {
       const conversation = {
         memberships: [
           {
@@ -70,7 +70,11 @@ describe('getGroupMemberships', () => {
       const result = getGroupMemberships(conversation, getConversationById)
         .memberships;
 
-      assert.isEmpty(result);
+      assert.lengthOf(result, 1);
+      assert.deepEqual(result[0], {
+        isAdmin: true,
+        member: unregisteredConversation,
+      });
     });
 
     it('hydrates memberships', () => {

diff --git a/ts/util/getGroupMemberships.ts b/ts/util/getGroupMemberships.ts
@@ -29,7 +29,7 @@ export const getGroupMemberships = (
   memberships: memberships.reduce(
     (result: Array<GroupV2Membership>, membership) => {
       const member = getConversationById(membership.conversationId);
-      if (!member || isConversationUnregistered(member)) {
+      if (!member) {
         return result;
       }
       return [...result, { isAdmin: membership.isAdmin, member }];