Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support file inclusion in the config in the same way that community Collector does #2536

Closed
tigrannajaryan opened this issue Feb 6, 2023 · 5 comments
Labels
enhancement Improvement to existing capability

Comments

@tigrannajaryan
Copy link
Contributor

The Otel Collector allows including files from the config, e.g.:

receivers:
  otlp:
    protocols:
      grpc:

exporters: ${file:receivers.yaml}

service:
  extensions: [ ]
  pipelines:
    traces:
      receivers:  [ otlp ]
      processors: [  ]
      exporters:  [ otlp ]

This does not work with Splunk distro of the Collector.

@rmfitzpatrick
Copy link
Contributor

rmfitzpatrick commented Feb 6, 2023

This is currently available with the include config source: https://github.com/signalfx/splunk-otel-collector/tree/main/internal/configsource/includeconfigsource

config_sources:
  include:

receivers:
  otlp:
    protocols:
      grpc:

exporters: ${include:exporters.yaml}

However, we should support this by reconciling the different config managers so that unknown* schemes are forwarded to the registered file provider:

fileProvider.Scheme(): configprovider.NewConfigSourceConfigMapProvider(

@tigrannajaryan
Copy link
Contributor Author

It is good that we have an equivalent feature. I think it is also important to avoid diverging / to converge on both source code and how it is used in the config (e.g. file vs include).

@atoulme atoulme added the enhancement Improvement to existing capability label Feb 24, 2023
@atoulme atoulme changed the title Support file inclusion in the config that community Collector does Support file inclusion in the config in the same way that community Collector does Mar 3, 2023
@rmfitzpatrick
Copy link
Contributor

This should be resolved by #2893

@rmfitzpatrick
Copy link
Contributor

Resolved by 70b75c7

@tigrannajaryan
Copy link
Contributor Author

@rmfitzpatrick nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing capability
Projects
None yet
Development

No branches or pull requests

3 participants